feat: Duplicate world list page #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 6341063417
💛 - Coveralls |
LautaroPetaccio
approved these changes
Sep 28, 2023
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.tsx
Outdated
Show resolved
Hide resolved
| @@ -128,7 +131,7 @@ export default class Routes extends React.Component<Props, State> { | |||
| <Route exact key={3} path={locations.landSelectENS()} component={LandSelectENSPage} />, | |||
| <Route exact key={4} path={locations.landAssignENS()} component={LandAssignENSPage} />, | |||
| <Route exact key={5} path={locations.ensSelectLand()} component={ENSSelectLandPage} /> | |||
| <Route exact path={locations.worlds()} component={WorldListPage} />, | |||
| <Route exact path={locations.worlds()} component={ToRenderWorldListPage} />, | |||
There was a problem hiding this comment.
Be aware that if you access the site via URL, you might not be able to load the new component as the FF might not have been queried yet.
There was a problem hiding this comment.
Good catch, I'll try it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2909
Duplicating the WorldListPage component that will then be modified in other prs for the new worlds for ens feature.