feat: Display dcl and ens worlds in worlds view #2933
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 6401348722
💛 - Coveralls |
| @@ -0,0 +1,3 @@ | |||
| export const fromBytesToMegabytes = (bytes: number) => { | |||
| return bytes / 1000000 | |||
There was a problem hiding this comment.
Updated to this in a future PR
return bytes / 1024 / 1024
| @@ -601,7 +601,8 @@ | |||
| "status_active": "Active", | |||
| "status_inactive": "Inactive", | |||
| "actions": "Actions", | |||
| "empty_url": "To activate this world you need to publish a scene" | |||
| "empty_url": "To activate this world you need to publish a scene", | |||
| "size": "Size mb" | |||
There was a problem hiding this comment.
What if we use the MB or Mb notation according to what they are?
| "size": "Size mb" | |
| "size": "Size MB" |
| "size": "Size mb" | |
| "size": "Size Mb" |
There was a problem hiding this comment.
Replaced all mb occurrences with Mb.
| @@ -0,0 +1,3 @@ | |||
| export const fromBytesToMegabytes = (bytes: number) => { | |||
| return bytes / 1000000 | |||
There was a problem hiding this comment.
We should divide the bytes for 1024^2 here, would you mind changing it?
There was a problem hiding this comment.
src/modules/worlds/sagas.ts
Outdated
| if (!address) { | ||
| address = yield select(getAddress) | ||
| } | ||
| const address = action.payload.address ?? (yield call(getAddressOrWaitConnection)) |
There was a problem hiding this comment.
Is this required? If the wallet connected successfully, the state must be populated with the address.
What do you think about removing it and make action.payload.address required?
There was a problem hiding this comment.
Removed it as it is not necessary anymore given that the request is made when the wallet connects.
| @@ -42,6 +42,11 @@ export const getExternalNamesForConnectedWallet = createSelector(getExternalName | |||
| return Object.values(externalNames).filter(externalName => isEqual(externalName.nftOwnerAddress, address)) | |||
| }) | |||
|
|
|||
| export const getExternalNamesForWallet = (wallet: string) => (state: RootState) => { | |||
There was a problem hiding this comment.
Would you mind adding tests for this new selector?
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com>
Closes #2931
Closes #2913
Closes #2914