Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Correct empty states #2942

Merged
merged 4 commits into from
Oct 5, 2023
Merged

feat: Correct empty states #2942

merged 4 commits into from
Oct 5, 2023

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Oct 4, 2023

Closes #2937

image image

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 3:12pm

@coveralls
Copy link

coveralls commented Oct 4, 2023

Pull Request Test Coverage Report for Build 6420835976

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 17.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Modals/DeployModal/DeployToWorld_WorldsForEnsOwnersFeature/DeployToWorld.tsx 0 2 0.0%
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.tsx 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Modals/DeployModal/DeployToWorld_WorldsForEnsOwnersFeature/DeployToWorld.tsx 1 0.0%
src/components/WorldListPage_WorldsForEnsOwnersFeature/WorldListPage.tsx 1 0.0%
Totals Coverage Status
Change from base Build 6420731041: -0.01%
Covered Lines: 3597
Relevant Lines: 16461

💛 - Coveralls

@@ -30,6 +30,7 @@ import WorldsStorage from './WorldsStorage'
import { TabType, useCurrentlySelectedTab } from './hooks'
import { DCLWorldsStatus, fromBytesToMegabytes, getDCLWorldsStatus } from './utils'
import './WorldListPage.css'
import classNames from 'classnames'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving this import up?

if (tab === TabType.DCL) {
onNavigate(locations.claimENS())
} else {
window.location.href = 'https://ens.domains'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding this as a configurable string?

Suggested change
window.location.href = 'https://ens.domains'
window.location.href = 'https://ens.domains'

@fzavalia fzavalia merged commit 101b1c8 into master Oct 5, 2023
7 checks passed
@fzavalia fzavalia deleted the feat/empty-states branch October 5, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create empty page state for not having any ENS name
3 participants