feat: SDK7 templates #2998
Merged
feat: SDK7 templates #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cazala
force-pushed
the
feat/sdk7-templates
branch
from
fa6e879
to
f53dccc
Compare
cazala
force-pushed
the
feat/sdk7-templates
branch
from
f53dccc
to
b3c518f
Compare
Pull Request Test Coverage Report for Build 7280241224
💛 - Coveralls |
cazala
force-pushed
the
feat/sdk7-templates
branch
from
b3c518f
to
ec0c912
Compare
cazala
force-pushed
the
feat/sdk7-templates
branch
from
833316c
to
da7f52f
Compare
cazala
commented
Dec 20, 2023
| @@ -27,6 +27,7 @@ export default class CustomLayoutModal extends React.PureComponent<Props, State> | |||
| handleBack = () => { | |||
| const { step } = this.state | |||
| switch (step) { | |||
| // TODO: remove this after removing the SDK7_TEMPLATES feature flag | |||
There was a problem hiding this comment.
I left several of these comments through the codebase to remember that once we remove the SDK7_TEMPLATES (because we won't want SDK6 templates anymore) then these are parts of the code that don't need to exist anymore (like the SDK version selection step)
| } | ||
| } | ||
|
|
||
| export const getIsCreateSceneOnlySDK7Enabled = (state: RootState) => { |
There was a problem hiding this comment.
Would you mind adding a simple test for these functions?
src/modules/project/selectors.ts
Outdated
| @@ -22,7 +22,9 @@ export const getUserProjects = createSelector(getAddress, getData, (address, pro | |||
| const project = projects[projectId] | |||
| const isOwnedByUser = !!project.ethAddress && !!address && isEqual(project.ethAddress, address) | |||
| if (isOwnedByUser || project.ethAddress === null) { | |||
| record[projectId] = project | |||
| if (!project.isTemplate) { | |||
There was a problem hiding this comment.
What do you think about joining the conditions?
(isOwnedByUser || project.ethAddress === null) && !project.isTemplate
LautaroPetaccio
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
@dcl/builder-templatespackage instead of loading them from the Builder Server