feat: add reclaim name flow #3027
Conversation
meelrossi
commented
Jan 29, 2024
meelrossi
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 7713186945
💛 - Coveralls |
src/components/Modals/ReclaimNameModal/ReclaimNameModal.spec.tsx
Outdated
Show resolved
Hide resolved
| expect(screen.getByText(t('ens_reclaim_name_modal.confirm_transaction'))).toBeInTheDocument() | ||
| }) | ||
|
|
||
| it('should show processing message when set resolver tx is loading', () => { |
There was a problem hiding this comment.
Would you mind adding a couple of tests that assert that the button is clickable when disableActions is true?
| })} | ||
| trigger={<DCLIcon name="info circle" />} | ||
| /> | ||
| <Popup on="click" content={t('ens_detail_page.tooltips.address')} trigger={<DCLIcon name="info circle" />} /> |
There was a problem hiding this comment.
There's a InfoTooltip component that sets up a Popup with the info button, would you mind trying to see if it works for this case?
| t('global.submit') | ||
| )} | ||
| </NetworkButton> | ||
| {!isEnsAddressEnabled ? ( |
There was a problem hiding this comment.
Isn't this removing the whole reclaim process if the isEnsAddress feature is not enabled?
There was a problem hiding this comment.
when it is enabled the user should never reach this page without reclaiming the name before.. its blocking the assign address and land buttons on the list and on the detail page
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com> Signed-off-by: Melisa Anabella Rossi <merossi@itba.edu.ar>
| @@ -22,6 +22,7 @@ export default class SignInPage extends React.PureComponent<Props> { | |||
|
|
|||
| render() { | |||
| const { isConnected, isAuthDappEnabled } = this.props | |||
| console.log({ isAuthDappEnabled }, 'HDASDASD') | |||
There was a problem hiding this comment.
A wild console log appeared 😆
Signed-off-by: Melisa Anabella Rossi <merossi@itba.edu.ar>
