Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: world permissions #3073

Merged
merged 60 commits into from
Apr 30, 2024
Merged

feat: world permissions #3073

merged 60 commits into from
Apr 30, 2024

Conversation

braianj
Copy link
Contributor

@braianj braianj commented Apr 5, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:24pm

@braianj braianj self-assigned this Apr 5, 2024
@coveralls
Copy link

coveralls commented Apr 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8899732270

Details

  • 221 of 243 (90.95%) changed or added relevant lines in 18 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.0%) to 46.94%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/ens/sagas.ts 2 3 66.67%
src/modules/worlds/sagas.ts 56 57 98.25%
src/modules/worlds/selectors.ts 2 3 66.67%
src/lib/api/peer.ts 1 4 25.0%
src/lib/api/worlds.ts 29 33 87.88%
src/lib/api/auth.ts 4 16 25.0%
Files with Coverage Reduction New Missed Lines %
src/lib/api/auth.ts 1 36.36%
src/lib/api/peer.ts 1 46.67%
Totals Coverage Status
Change from base Build 8878264505: 1.0%
Covered Lines: 5402
Relevant Lines: 10498
💛 - Coveralls

@braianj braianj added the enhancement A feature or a fix that has low priority label Apr 19, 2024
LautaroPetaccio
LautaroPetaccio reviewed Apr 30, 2024
View reviewed changes
src/modules/worlds/reducer.ts Outdated

export type WorldsState = {
// TODO: Find a use for the data object when there is something more relevant as the core data for the worlds module.
data: Record<string, unknown>
walletStats: Record<string, WorldsWalletStats>
worldsPermissions: Record<string, WorldPermissions>
profiles: Record<string, Avatar>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the profiles here?

src/modules/worlds/reducer.spec.ts Outdated Show resolved Hide resolved
src/modules/worlds/reducer.spec.ts Outdated Show resolved Hide resolved
src/modules/worlds/reducer.spec.ts Outdated Show resolved Hide resolved
src/modules/worlds/reducer.spec.ts Outdated Show resolved Hide resolved
src/modules/worlds/reducer.spec.ts Outdated Show resolved Hide resolved
@braianj braianj merged commit 55616cd into master Apr 30, 2024
7 checks passed
@braianj braianj deleted the feat/world-permissions branch April 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LautaroPetaccio LautaroPetaccio LautaroPetaccio approved these changes

Assignees

@braianj braianj

Labels
enhancement A feature or a fix that has low priority
Projects
Platform Team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@braianj @coveralls @LautaroPetaccio