Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add wearable utility #3096

Merged
merged 5 commits into from
May 3, 2024
Merged

Conversation

LautaroPetaccio
Copy link
Contributor

This PR adds the wearable utility property to the items. Items can now be saved with this property that will be later shown in the Marketplace.

Screenshot 2024-05-03 at 16 03 00

Screenshot 2024-05-03 at 16 27 26

Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 8:13pm

@coveralls
Copy link

coveralls commented May 3, 2024

Pull Request Test Coverage Report for Build 8944350089

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 46.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/api/builder.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 8928139064: 0.005%
Covered Lines: 5407
Relevant Lines: 10504

💛 - Coveralls

@@ -28,6 +30,7 @@ export default class ItemImage extends React.PureComponent<Props> {
<RarityBadge className="rarity-badge" rarity={item.rarity} size="medium" withTooltip />
) : null}
{hasBadge ? <ItemBadge item={item} size={badgeSize} /> : null}
{hasUtilityBadge ? <IconBadge text={t('global.utility')} icon="utility" /> : null}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{hasUtilityBadge ? <IconBadge text={t('global.utility')} icon="utility" /> : null}
{hasUtilityBadge && !!item.utility ? <IconBadge text={t('global.utility')} icon="utility" /> : null}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it, good catch!

Copy link
Contributor

@cyaiox cyaiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@LautaroPetaccio LautaroPetaccio merged commit 462f533 into master May 3, 2024
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-wearable-utility branch May 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants