Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SW max file size calculation #3114

Merged
merged 4 commits into from
Jun 6, 2024
Merged

fix: SW max file size calculation #3114

merged 4 commits into from
Jun 6, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Jun 6, 2024

This PR updates the logic that calculates the max file size for the smart wearables.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:33pm

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9407403369

Details

  • 3 of 15 (20.0%) changed or added relevant lines in 3 files are covered.
  • 216 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 47.434%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/sagas.ts 3 4 75.0%
src/modules/item/errors.tsx 0 2 0.0%
src/modules/item/export.ts 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/WorldListPage/WorldContributorTab/WorldContributorTab.tsx 3 85.37%
src/modules/location/sagas.ts 4 75.0%
src/modules/identity/sagas.ts 7 19.33%
src/modules/scene/sagas.ts 9 8.02%
src/modules/item/sagas.ts 21 88.01%
src/modules/land/sagas.ts 44 14.65%
src/modules/project/sagas.ts 47 23.43%
src/modules/collection/sagas.ts 81 66.67%
Totals Coverage Status
Change from base Build 9406517417: 0.02%
Covered Lines: 5524
Relevant Lines: 10643

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9407417588

Details

  • 4 of 16 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 47.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/sagas.ts 4 5 80.0%
src/modules/item/errors.tsx 0 2 0.0%
src/modules/item/export.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 9406517417: -0.01%
Covered Lines: 5530
Relevant Lines: 10666

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9407434403

Details

  • 4 of 16 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 47.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/sagas.ts 4 5 80.0%
src/modules/item/errors.tsx 0 2 0.0%
src/modules/item/export.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 9406517417: -0.01%
Covered Lines: 5530
Relevant Lines: 10666

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9407616737

Details

  • 4 of 16 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 47.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/sagas.ts 4 5 80.0%
src/modules/item/errors.tsx 0 2 0.0%
src/modules/item/export.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 9406517417: -0.01%
Covered Lines: 5530
Relevant Lines: 10666

💛 - Coveralls

@cyaiox cyaiox enabled auto-merge (squash) June 6, 2024 21:28
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9408075665

Details

  • 4 of 16 (25.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 47.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/modules/item/sagas.ts 4 5 80.0%
src/modules/item/errors.tsx 0 2 0.0%
src/modules/item/export.ts 0 9 0.0%
Totals Coverage Status
Change from base Build 9408065984: -0.01%
Covered Lines: 5530
Relevant Lines: 10666

💛 - Coveralls

@cyaiox cyaiox merged commit 711ed86 into master Jun 6, 2024
6 checks passed
@cyaiox cyaiox deleted the fix/sw-calculate-size branch June 6, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants