fix: ens indefinitely loading #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meelrossi
force-pushed
the
fix/ens-loading
branch
from
4e57cb4
to
65abdf4
Compare
Pull Request Test Coverage Report for Build 9450706759Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9450768286Details
💛 - Coveralls |
cyaiox
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching for names, if the name had any uppercase letter it wasn't able to find the correct ens in the state as it was being saved in lowercase. This PRs adds a fix that compares the subdomains in lowercase when searching for a specific name in the store
Closes #3119 3119