feat: add validation not repeated slots in emotes

src/validations/access-checker/profiles.ts

@@ -3,7 +3,7 @@ import { parseUrn } from '@dcl/urn-resolver'
 import { OK, Validation, validationFailed } from '../../types'
 import { isOldEmote } from '../profile'
 import { ADR_74_TIMESTAMP, ADR_75_TIMESTAMP } from '../timestamps'
-import { conditionalValidation, validationAfterADR75, validationGroup } from '../validations'
+import { conditionalValidation, validationAfterADR74, validationAfterADR75, validationGroup } from '../validations'
 
 export const pointerIsValid: Validation = {
   validate: async ({ externalCalls }, deployment) => {
@@ -126,4 +126,19 @@ export const ownsItems: Validation = conditionalValidation(
   }
 )
 
-export const profiles: Validation = validationGroup(pointerIsValid, ownsNames, ownsItems)
+export const profileSlotsAreNotRepeated: Validation = validationAfterADR74({
+  validate: async (components, deployment) => {
+    const allAvatars: Avatar[] = deployment.entity.metadata?.avatars ?? []
+    const allEmotes: { slot: number }[] = allAvatars.flatMap((avatar) => avatar.avatar.emotes ?? [])
+    const usedSlots = new Set()
+    for (const { slot } of allEmotes) {
+      if (usedSlots.has(slot)) {
+        return validationFailed('Emote slots should not be repeated.')
+      }
+      usedSlots.add(slot)
+    }
+    return OK
+  }
+})
+
+export const profiles: Validation = validationGroup(pointerIsValid, ownsNames, ownsItems, profileSlotsAreNotRepeated)

test/unit/validations/profiles.spec.ts

@@ -1,6 +1,7 @@
 import { EntityType } from '@dcl/schemas'
 import sharp from 'sharp'
 import { ValidationResponse } from '../../../src'
+import { profileSlotsAreNotRepeated } from '../../../src/validations/access-checker/profiles'
 import {
   emoteUrns,
   faceThumbnail,
@@ -377,5 +378,23 @@ describe('Profiles', () => {
         'The slot 10 of the emote urn:decentraland:matic:collections-v2:0xa7f6eba61566fd4b3012569ef30f0200ec138aa5:0 must be a number between 0 and 9 (inclusive).'
       )
     })
+
+    it('After ADR 74, when emote slots are repaated, should return the correct error', async () => {
+      const entity = buildEntity({
+        type: EntityType.PROFILE,
+        metadata: validProfileMetadataWithEmotes([
+          { slot: 0, urn: 'urn:decentraland:matic:collections-v2:0xa7f6eba61566fd4b3012569ef30f0200ec138aa5:0' },
+          { slot: 1, urn: 'urn:decentraland:matic:collections-v2:0xa7f6eba61566fd4b3012569ef30f0200ec138aa5:0' },
+          { slot: 1, urn: 'urn:decentraland:matic:collections-v2:0xa7f6eba61566fd4b3012569ef30f0200ec138aa5:0' }
+        ]),
+        timestamp: ADR_74_TIMESTAMP + 1
+      })
+      const deployment = buildDeployment({ entity })
+
+      const result = await profileSlotsAreNotRepeated.validate(components, deployment)
+
+      expect(result.ok).toBeFalsy()
+      expect(result.errors).toContain('Emote slots should not be repeated.')
+    })
   })
 })