Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PausableToken for MANA #22

Closed
eordano opened this issue Jul 25, 2017 · 10 comments
Closed

Implement PausableToken for MANA #22

eordano opened this issue Jul 25, 2017 · 10 comments
Labels

Comments

@eordano
Copy link
Member

eordano commented Jul 25, 2017

The MANA token should be pausable

https://github.com/OpenZeppelin/zeppelin-solidity/blob/master/contracts/token/PausableToken.sol

@maraoz
Copy link
Contributor

maraoz commented Jul 26, 2017

ACK, ping @federicobond

@federicobond
Copy link
Contributor

Pausable is Ownable, but the token is owned by the Crowdsale contract. We can forward those pause/unpause calls via pauseToken/unpauseToken methods in the crowdsale.

@maraoz
Copy link
Contributor

maraoz commented Jul 26, 2017

IMO, token should be paused right after construction, and only unpaused manually after the crowdsale ends, via the foundation's multisig, probably proxying through the continous token sale contract.

@maraoz
Copy link
Contributor

maraoz commented Jul 26, 2017

i.e: we don't need to enable transfers during the crowdsale event

@maraoz
Copy link
Contributor

maraoz commented Jul 30, 2017

@federicobond can you implement this?
@eordano comments?

@maraoz
Copy link
Contributor

maraoz commented Aug 8, 2017

@federicobond @eordano there doesn't seem to be a way to unpause the token with current version

@federicobond
Copy link
Contributor

That seems to be the case. We are missing the proxy calls to pause/unpause from the MANAContinuousSale contract which owns the token.

@federicobond federicobond reopened this Aug 8, 2017
@maraoz
Copy link
Contributor

maraoz commented Aug 8, 2017

@federicobond token should be paused on token sale contructor, as explained here: #22 (comment)

@federicobond
Copy link
Contributor

Fixed in #30

@maraoz maraoz closed this as completed Aug 9, 2017
@nachomazzara
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants