feat: handle auction bid success event #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosantangelo
force-pushed
the
feat/auction-events
branch
from
6a622f1
to
de510e1
Compare
nicosantangelo
force-pushed
the
feat/auction-events
branch
from
de510e1
to
b9abc8c
Compare
scripts/addAuctionTimestamp.sql
Outdated
| @@ -0,0 +1 @@ | |||
| UPDATE parcels SET auction_timestamp = 1517356800000 where auction_owner IS NOT NULL AND auction_price IS NOT NULL; | |||
There was a problem hiding this comment.
Should we add this query to the migration up? how can we run it?
There was a problem hiding this comment.
you're right, historically we've been running .sql files directly on the server, but this should be done each time the migration runs, I'll change it 👍
Had to add a new migration, also updated initDb
| @@ -31,18 +31,6 @@ export class Asset { | |||
| return assets[0] | |||
| } | |||
|
|
|||
| findByIds(ids) { | |||
There was a problem hiding this comment.
Why we are removing it?
There was a problem hiding this comment.
Not used anywhere and was a security concern, ids was being interpolated and could be SQL injected
| @@ -33,10 +33,6 @@ export class Parcel extends Model { | |||
| return splitCoordinate(id) | |||
| } | |||
|
|
|||
| static findByIds(ids) { | |||
There was a problem hiding this comment.
Why we are removing it?
There was a problem hiding this comment.
Not used anywhere and was a security concern, ids was being interpolated and could be SQL injected
nicosantangelo
force-pushed
the
feat/auction-events
branch
from
ac44c75
to
b3828c4
Compare
cazala
approved these changes
Nov 20, 2018
This was referenced Feb 2, 2024
This was referenced Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires a migrate up!
Closes #612