Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

castShadows property not working #189

Open
nearnshaw opened this issue Dec 13, 2022 · 1 comment
Open

castShadows property not working #189

nearnshaw opened this issue Dec 13, 2022 · 1 comment
Assignees
Labels
3-low Low importance / Nice to have bug Something isn't working unity

Comments

@nearnshaw
Copy link
Member

nearnshaw commented Dec 13, 2022

In PBR materials, the CastShadows property works as expected. But it doesn't in basic materials.

The castShadows property in a basic material doesn't affect the rendering of other entities. It never casts any shadow. If castShadows is true, I should see shadows on other entities. Even though the material of the entity is unlit, it should be able to affect the lighting of other entities.

Otherwise we should mark the castShadows property as deprecated and remove it from the Creator Hub UI for Basic materials.

PBR with castShadow
Image

PBR without castShadow
Image

Basic is the same with or without castShadow
Image

@0xD-Fabio
Copy link

0xD-Fabio commented Jan 27, 2023

Fixed part of the bug on the SDK7 in this PR.
Working on this issue, we found out that the SDK7 rendereable are not been culled and we opened an issue.

@aixaCode aixaCode added the bug Something isn't working label Nov 7, 2023
@nearnshaw nearnshaw transferred this issue from decentraland/sdk Oct 10, 2024
@nearnshaw nearnshaw added 3-low Low importance / Nice to have and removed requires validation labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-low Low importance / Nice to have bug Something isn't working unity
Projects
Status: Todo
Development

No branches or pull requests

3 participants