Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

castShadows property not working #513

Open
nearnshaw opened this issue Dec 13, 2022 · 1 comment
Open

castShadows property not working #513

nearnshaw opened this issue Dec 13, 2022 · 1 comment
Assignees
@0xD-Fabio
Labels
bug Something isn't working renderer
Milestone
Workspace

Comments

@nearnshaw
Copy link
Member

nearnshaw commented Dec 13, 2022 •
edited by pbosio

The castShadows property in a material doesn't affect the rendering of the entities. It always casts a shadow, with or without it

example:

https://playground.decentraland.org/?code=CmNvbnN0IG1lc2hFbnRpdHkgPSBlbmdpbmUuYWRkRW50aXR5KCkKVHJhbnNmb3JtLmNyZWF0ZShtZXNoRW50aXR5LCB7IAogIHBvc2l0aW9uOiBWZWN0b3IzLmNyZWF0ZSg0LCAzLjUsIDQpLApzY2FsZTogVmVjdG9yMy5jcmVhdGUoNCwgNCwgNCkgfSkKCgpNZXNoQ29sbGlkZXIuc2V0Qm94KG1lc2hFbnRpdHkpCk1lc2hSZW5kZXJlci5zZXRCb3gobWVzaEVudGl0eSkKCmNvbnN0IHRleHR1cmVTb3VyY2U6IEdlbmVzaXNQbGF6YUNvbnRlbnQgPSAnaW1hZ2VzL3BvcnRyYWl0cy9iZXR0eS5wbmcnCk1hdGVyaWFsLnNldFBick1hdGVyaWFsKG1lc2hFbnRpdHksIHsKICAgIHRleHR1cmU6IHsKICAgICAgIHRleDogewogICAgICAgICAkY2FzZTogInRleHR1cmUiLAogICAgICAgICB0ZXh0dXJlOiB7CiAgICAgICAgICAgIHNyYyA6IHRleHR1cmVTb3VyY2UsCiAgICAgICAgICAgIHdyYXBNb2RlOiAwCiAgICAgICAgIH0KICAgICAgIH0KICB9LAogIGNhc3RTaGFkb3dzOiBmYWxzZSwKICBhbGJlZG9Db2xvcjogIHtyOiAxLCBnOjAuNSwgYjogMC41fSwKfSApCgo%3D
@nearnshaw nearnshaw modified the milestones: SDK 7.1 - Beta, SDK 7.2 - Public release Dec 13, 2022
@menduz menduz added the sdk7-blocker Blocks the GA release of SDK7 label Dec 20, 2022
@pbosio pbosio added the renderer label Jan 6, 2023
@0xD-Fabio 0xD-Fabio self-assigned this Jan 16, 2023
This was referenced Jan 18, 2023
Closed
Merged
@0xD-Fabio
Copy link

0xD-Fabio commented Jan 27, 2023 •
edited

Fixed part of the bug on the SDK7 in this PR.
Working on this issue, we found out that the SDK7 rendereable are not been culled and we opened an issue.

@nearnshaw nearnshaw modified the milestones: SDK 7.2 - Public release, Workspace Mar 2, 2023
@nearnshaw nearnshaw removed the sdk7-blocker Blocks the GA release of SDK7 label Apr 11, 2023
@aixaCode aixaCode added the bug Something isn't working label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xD-Fabio 0xD-Fabio

Labels
bug Something isn't working renderer
Projects
SDK
Status: No status
Milestone
Workspace
Development

No branches or pull requests
5 participants
@menduz @nearnshaw @pbosio @aixaCode @0xD-Fabio