Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix error when SVG icon is not available in the file system' to v0.26 #11008

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Backport #10988 to v0.26

♥️ Thank you!

@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug labels Jun 14, 2023
@alecslupu alecslupu added this to the 0.26.8 milestone Jun 14, 2023
@alecslupu alecslupu force-pushed the backport/0.26/fix-error-when-svg-icon-is-not-10988 branch from 3ea447e to 618e6b4 Compare June 14, 2023 13:19
@alecslupu alecslupu force-pushed the backport/0.26/fix-error-when-svg-icon-is-not-10988 branch from 618e6b4 to c186aef Compare June 14, 2023 19:12
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a CodeQL alert, can you check it out 🙏🏽 ?

decidim-core/app/helpers/decidim/layout_helper.rb Outdated Show resolved Hide resolved
@andreslucena
Copy link
Member

There's a CodeQL alert, can you check it out 🙏🏽 ?

The alert is still on but it's actually on develop too: https://github.com/decidim/decidim/security/code-scanning/35
So I'd said that we can ignore for now

@alecslupu
Copy link
Contributor Author

@andreslucena this can be retaken.

Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's really clean, thanks!!

@andreslucena andreslucena merged commit efa22da into release/0.26-stable Jun 19, 2023
@andreslucena andreslucena deleted the backport/0.26/fix-error-when-svg-icon-is-not-10988 branch June 19, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants