Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 'Fix flash of admin inputs, panels and dropdowns' to v0.28 #12264

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Backport #12203 to v0.28

♥️ Thank you!

* Fix flash of foundation dropdown menus in filters

* Fix flash of inputs in organizations' social networks

* Fix flash of diff contents in activity log

* Fix flash of inputs in form builder for translated fields

* Fix flash of inputs in assemblies' social networks

* Prevent unstyled Filter button

Detected on code review
@andreslucena andreslucena added backport Pull Requests that are a backport for a fixed bug contract: redesign Barcelona City Council contract module: admin type: fix PRs that implement a fix for a bug labels Jan 8, 2024
@andreslucena
Copy link
Member Author

Only failing spec is the flaky from spec/system/admin_manages_organization_spec.rb, so this is ready to be reviewed

Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merging with unrelated failing spec.

@alecslupu alecslupu added this to the 0.28.1 milestone Jan 9, 2024
@alecslupu alecslupu merged commit 9786165 into release/0.28-stable Jan 9, 2024
106 of 108 checks passed
@alecslupu alecslupu deleted the backport/0.28/fix-flash-of-admin-inputs-pane-12203 branch January 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug contract: redesign Barcelona City Council contract module: admin type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants