-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 'Refactor of events specs (part 2)' to v0.27 #12508
Merged
andreslucena
merged 3 commits into
release/0.27-stable
from
backport/0.27/refactor-of-events-specs-part--12147
Feb 26, 2024
Merged
Backport 'Refactor of events specs (part 2)' to v0.27 #12508
andreslucena
merged 3 commits into
release/0.27-stable
from
backport/0.27/refactor-of-events-specs-part--12147
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor of initiative_sent_to_technical_validation_event_spec * Refactor of initiative_sent_to_technical_validation_event_spec * Refactor of opened_survey_event_spec * deletion of commented out test * Refactor of polling_station_assigned_event_spec * Refactor vote_accepted_event_spec * Refactor election_published_event_spec * Refactor of notify_trustee_new_election_event_spec * Refactor of notify_new_trustee_event_spec * Refactor of creation_enabled_event_spec * Refactor of creation_disabled_event_spec * refactor of profile_updated_event_officialize_user_spec * reformating of profile_updated_event_officialize_user_spec * Refactor of user_group_updated_event_spec (BROKEN) * Refactor of profile_updated_event_spec * Refactor of create_post_event_spec * Refactor of conference_role_assigned_event_spec * Refactor of create_assembly_member_event_spec * Refactor of user_group_created_event_spec (BROKEN SHAKERPACKER) * Refactor of decidim-admin/spec/events/decidim/component_published_event_spec.rb * Refactor of component_published_event_spec * Refactor of attachment_created_event_spec * Refactor of resource_hidden_event_spec * Refactor of role_assigned_to_assembly_event_spec * Refactor of user_mentioned_event_spec * Refactor of user_mentioned_event_spec (styling fix) * Refactor of create_initiative_event_spec * Refactor of closed_survey_event_spec * Refactor of create_debate_event_spec * Refactor of create_debate_event_spec (styling) * Refactor of comment_by_followed_user_event_spec * Refactor of comment_by_followed_user_group_event_spec * Refactor of comment_created_event_spec * Refactor of reply_created_event_spec * Refactor of reply_created_event_spec (styling) * Refactor of user_group_mentioned_event_spec (shakerpacker issue) * Refactor of user_group_mentioned_event_spec (styling) * Refactor of profile_updated_event_spec * Refactor of result_progress_updated_event_spec * Refactor of proposal_linked_event_spec * Refactor fix for decidim-accountability/spec/events/decidim/accountability/proposal_linked_event_spec.rb (NEW) * Refactor of decidim-accountability/spec/events/decidim/accountability/result_progress_updated_event_spec.rb (NEW) * Refactor of decidim-comments/spec/events/decidim/comments/comment_by_followed_user_group_event_spec.rb (NEW) * Refactor of decidim-comments/spec/events/decidim/comments/user_group_mentioned_event_spec.rb * Update decidim-accountability/spec/events/decidim/accountability/result_progress_updated_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-blogs/spec/events/decidim/blogs/create_post_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-comments/spec/events/decidim/comments/user_group_mentioned_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-debates/spec/events/decidim/debates/create_debate_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Refactor of decidim-comments/spec/events/decidim/comments/user_group_mentioned_event_spec (CLI FIX) * Update decidim-elections/spec/events/decidim/elections/trustees/notify_new_trustee_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-elections/spec/events/decidim/elections/trustees/notify_trustee_new_election_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-initiatives/spec/events/decidim/initiatives/admin/initiative_sent_to_technical_validation_event_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Update decidim-initiatives/spec/events/decidim/initiatives/admin/initiative_sent_to_technical_validation_event_spec.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Update decidim-elections/spec/events/decidim/elections/trustees/notify_trustee_new_election_event_spec.rb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
added
backport
Pull Requests that are a backport for a fixed bug
module: core
type: fix
PRs that implement a fix for a bug
labels
Feb 21, 2024
… backport/0.27/refactor-of-events-specs-part--12147
andreslucena
approved these changes
Feb 26, 2024
Only failing spec is the codecov check, so I'll merge this |
andreslucena
deleted the
backport/0.27/refactor-of-events-specs-part--12147
branch
February 26, 2024 17:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Pull Requests that are a backport for a fixed bug
module: core
type: fix
PRs that implement a fix for a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backport #12147 to v0.27