Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow external SD card storage; cleanups #24

Closed
wants to merge 6 commits into from

Conversation

ollo22
Copy link

@ollo22 ollo22 commented Oct 2, 2023

This PR allows revancify users to set the apk target folder, via

internalStorage=/storage/XXXX-XXXX ~/Revancify/revancify

It also cleans up some problematic code, though plenty of it remains. I'll point this out in separate GH issues.

If the authors are interested, this could be further developed (i.e. add a command-line switch, and update user-facing messages to reflect the actual storage location).

@decipher3114
Copy link
Owner

Repeated ping is an intended behaviour which checks internet everytime the user tries to access any option that requires internet.

Declaring it once may not cover up the cases in which the internet is not available after launching it.

@ollo22
Copy link
Author

ollo22 commented Oct 3, 2023

Fine, I can revert the ping. Perhaps factor it into a function, configurable via some CLI switch.

The problem is that on my phone, a simple ping -c 1 google.com; ping -c 1 google.com often hangs at the second ping. So the repeated checks often make revancify think the net is down. Moreover, one could argue that, even with repeated checks, the net could go down between the ping-check and the actual network op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants