Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat(#66): draw multiple circles #431

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

janscheidegger
Copy link
Contributor

@janscheidegger janscheidegger commented Oct 23, 2019

Create Interface for drawables
Abstract x/y to point
Drawables know how to draw themselfes
Save currently Drawing element at last position in array and change on move
Clear Canvas and draw whole array at once

Create Interface for drawables
Abstract x/y to point
Drawables know how to draw themselfes
Save currently Drawing element at last position in array and change on move
Clear Canvas and draw whole array at once
@janscheidegger
Copy link
Contributor Author

Tested Remote Part and draw-webcomponent seems ok to me. Would be cool if someone else could take a look and provide some feedback. I will adjust the code then if necessary.

I have the feeling that drawing is a little bit off, meaning the line does not exactly appear where my finger is. But it is the same in the current version.

With this change we are now easily able to implement new forms and colors.

@peterpeterparker
Copy link
Contributor

I tested the remote part in the demo kit, looks good to me too 👍

About "a little bit off" agree it's already the case, I hope that this will be improved and fixed once I'm done with the rework of the UX of the remote (#228) as the aspect ratio of the deck will change

@peterpeterparker peterpeterparker added enhancement New feature or request hacktoberfest-accepted Good for Hacktoberfest remote Remote control labels Oct 25, 2019
@peterpeterparker peterpeterparker merged commit 358496a into deckgo:master Oct 25, 2019
@peterpeterparker
Copy link
Contributor

I tested the remote control app part too, it's all good, thx for the cool PR and awesome work 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request hacktoberfest-accepted Good for Hacktoberfest remote Remote control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants