Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FAB-118] Fix canvas fit on mobile screen #48

Merged
merged 11 commits into from
Sep 25, 2021

Conversation

nicolauscg
Copy link
Member

@nicolauscg nicolauscg commented Sep 22, 2021

behavior after bug fixes FAB-116, FAB-117, FAB-118

  • translation scaling is dynamic, so drawing after resizing screen will be correct
  • drawing session screen not scrollable in small screens
  • canvas contained in small screen
  • when screen is short and wide, no white background below screen before drawing session (fixed by adding overflow-y-hidden when invisible)
  • canvas height can now shrink when screen/canvas width stays constant

Todo

  • canvas always fit screen, even on mobile
  • resizing only screen height will correctly adjust canvas dimension
  • dynamically adjust scaling factor for canvas translation when screen is resized

@nicolauscg nicolauscg self-assigned this Sep 23, 2021
@daystram daystram changed the title Fix/fit canvas screen mobile [FAB-118] Fix canvas fit on mobile screen Sep 24, 2021
@daystram daystram temporarily deployed to Development September 24, 2021 13:52 Inactive
@daystram daystram temporarily deployed to Development September 24, 2021 13:52 Inactive
@daystram daystram temporarily deployed to Development September 24, 2021 13:55 Inactive
@daystram daystram merged commit 32b4feb into master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants