Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to tailwind v3 #89

Closed
wants to merge 3 commits into from
Closed

chore: Migrate to tailwind v3 #89

wants to merge 3 commits into from

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Mar 10, 2023

Migrates to twind v1, thus unlocking tailwind v3.

Note that VSCode intellisense got worse since their plugin still does not support v1. However, they will eventually support it. To circumvent some issues regarding intellisense, I created a new file contaning all twind's config, while leaving the old format intact so we can still benefit from some intellisense for color/text/border customizations

@igorbrasileiro
Copy link
Contributor

Have you saw something related to css duplication?
denoland/fresh#1050

@igorbrasileiro
Copy link
Contributor

This changes may not work well with the deco-sites/std. Did you see something weird?

@@ -40,11 +40,11 @@ function ProductDetails({ page }: Props) {
<Container class="py-0 sm:py-10">
<div class="flex flex-col gap-4 sm:flex-row sm:gap-10">
{/* Image Gallery */}
<div class="flex flex-row overflow-auto scroll-x-mandatory scroll-smooth sm:gap-2">
<div class="flex flex-row overflow-auto snap-x snap-mandatory scroll-smooth sm:gap-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:satisfaction:

@igorbrasileiro
Copy link
Contributor

igorbrasileiro commented Mar 10, 2023

Carousel arrows are broken
image

@igorbrasileiro
Copy link
Contributor

Note that VSCode intellisense got worse since their plugin still does not support v1.

https://twind.style/packages/@twind/intellisense#createintellisense será que isso não resolve @tlgimenes ?

@tlgimenes
Copy link
Contributor Author

closing in favor of #160

@tlgimenes tlgimenes closed this Apr 18, 2023
@tlgimenes tlgimenes deleted the feat/tailwind-v3 branch April 18, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants