Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make develop the default branch #3

Closed
szepeviktor opened this issue Oct 6, 2020 · 2 comments · Fixed by #6
Closed

Make develop the default branch #3

szepeviktor opened this issue Oct 6, 2020 · 2 comments · Fixed by #6

Comments

@szepeviktor
Copy link
Contributor

...as contributors should send PR-s to the develop branch.

@betterthanclay
Copy link
Member

I've gone back and forth on this issue - most advice ultimately ends up sticking with master / main as your default branch as it should be the responsibility of developers to direct pull requests to the correct branch. The default branch should be the one that gives the end user a stable environment.

In practise, that then leaves pull requests prone to targeting the wrong branch. There isn't really a good solution.
I've set it to develop for now, but may switch back again.

There's a good discussion about it here - OriginProtocol/origin-js#123

@szepeviktor
Copy link
Contributor Author

I have an idea...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants