txscript: add stake opcode tests. #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Aug 6, 2018
txscript/data/script_tests.json
Outdated
|
|
||
| ["SSTX related tests"], | ||
| ["1 1 ADD", "SSTX 2 OP_EQUAL", "NONE", "OK", "SSTX is a NOP"], | ||
| ["DATA_5 DATA_4 0x7a{4}", "SSTX HASH160 DATA_20 0x246bda0f2b9aba6dc78c6259970e45e6af960d46 EQUAL", "NONE", "ERR_EVAL_FALSE", "SSTX false eval"], |
There was a problem hiding this comment.
I'd suggest SSTX almost P2SH for the comment since it's a bit more descriptive. Likewise for the others.
davecgh
requested changes
Sep 10, 2018
txscript/data/script_tests.json
Outdated
| ["SSTX related tests"], | ||
| ["1 1 ADD", "SSTX 2 OP_EQUAL", "NONE", "OK", "SSTX is a NOP"], | ||
| ["DATA_5 DATA_4 0x7a{4}", "SSTX HASH160 DATA_20 0x246bda0f2b9aba6dc78c6259970e45e6af960d46 EQUAL", "NONE", "ERR_EVAL_FALSE", "SSTX almost P2SH"], | ||
| ["DATA_5 1 3 DATA_2 ADD SSTX", "HASH160 DATA_20 0x30c7ecf9ff5508c105071194d979b13ed90a82b7 EQUAL", "NONE", "OK", "SSTX (P2SH)"], |
There was a problem hiding this comment.
As with #1381, these aren't all actually testing the intended thing, rather they're just pushing data to the stack.
davecgh
requested changes
Sep 11, 2018
txscript/data/script_tests.json
Outdated
| ["SSTX related tests"], | ||
| ["1 1 ADD", "SSTX 2 OP_EQUAL", "NONE", "OK", "SSTX is a NOP"], | ||
| ["DATA_5 DATA_4 0x7a{4}", "SSTX HASH160 DATA_20 0x246bda0f2b9aba6dc78c6259970e45e6af960d46 EQUAL", "NONE", "ERR_EVAL_FALSE", "SSTX almost P2SH"], | ||
| ["1 3 DATA_2 ADD SSTX", "HASH160 DATA_20 0xdcbd287f8a23bf97cea3c77392854976a6feff8f EQUAL", "NONE", "ERR_P2SH_STAKE_OPCODES", "SSTX (P2SH)"], |
There was a problem hiding this comment.
Comment should call out the SSTX is invalid in a p2sh script. Same with others.
davecgh
approved these changes
Sep 11, 2018
vctt94
pushed a commit
to vctt94/dcrd
that referenced
this pull request
Mar 29, 2019
addrmgr: store address' supported service bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work towards #1331.