-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: add getnetworkinfo rpc. #1536
Conversation
b86dddb
to
45d2c86
Compare
8aba1c8
to
14239f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is producing incorrect results in terms of the local addresses:
The following is output from my local tests:
"localaddresses": [
{
"address": "",
"port": 0,
"score": 0
},
{
"address": "",
"port": 0,
"score": 0
},
{
"address": "",
"port": 0,
"score": 0
},
{
"address": "",
"port": 0,
"score": 0
},
{
"address": "",
"port": 0,
"score": 0
},
...
7daf0a0
to
4a8ba23
Compare
4a8ba23
to
b3c0e69
Compare
b3c0e69
to
65d2f7b
Compare
65d2f7b
to
86da32e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please don't forget to update the JSON-RPC API documentation to add the new method.
86da32e
to
cffd771
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest updates looks good and reports the information as expected.
This requires PR #1522.