Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: add getnetworkinfo rpc. #1536

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Nov 27, 2018

This requires PR #1522.

@davecgh davecgh added this to the 1.5.0 milestone Dec 3, 2018
@dnldd dnldd force-pushed the getnetworkinfo_rpc branch 2 times, most recently from 8aba1c8 to 14239f9 Compare April 14, 2019 22:17
server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
addrmgr/addrmanager.go Outdated Show resolved Hide resolved
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is producing incorrect results in terms of the local addresses:

The following is output from my local tests:

  "localaddresses": [
    {
      "address": "",
      "port": 0,
      "score": 0
    },
    {
      "address": "",
      "port": 0,
      "score": 0
    },
    {
      "address": "",
      "port": 0,
      "score": 0
    },
    {
      "address": "",
      "port": 0,
      "score": 0
    },
    {
      "address": "",
      "port": 0,
      "score": 0
    },
    ...

rpcserver.go Outdated Show resolved Hide resolved
@dnldd dnldd force-pushed the getnetworkinfo_rpc branch 4 times, most recently from 7daf0a0 to 4a8ba23 Compare June 13, 2019 22:07
addrmgr/addrmanager.go Show resolved Hide resolved
addrmgr/addrmanager.go Outdated Show resolved Hide resolved
rpcserverhelp.go Outdated Show resolved Hide resolved
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please don't forget to update the JSON-RPC API documentation to add the new method.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest updates looks good and reports the information as expected.

@davecgh davecgh merged commit b693029 into decred:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants