Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mempool: Optimize pool double spend check. #1561

Merged
merged 2 commits into from
Jan 4, 2019
Merged

mempool: Optimize pool double spend check. #1561

merged 2 commits into from
Jan 4, 2019

Conversation

zeoio
Copy link
Contributor

@zeoio zeoio commented Jan 3, 2019 •
edited by davecgh
Loading

This optimizes checkPoolDoubleSpend to check the traversal position first since it is more likely.

Update mempool.go
e570885 
mempool: optimized code
davecgh
davecgh requested changes Jan 4, 2019
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not following the guidelines despite checking all of the boxes.

@davecgh davecgh changed the title Update mempool.go mempool: Optimize pool double spend check. Jan 4, 2019
mempool: Optimize pool double spend check.
5cf5089 
This optimizes the checkPoolDoubleSpend to check the traversal position first since it is more likely.
davecgh
davecgh approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should only be a single commit, but I'll go ahead and approve this and squash it since the second commit is accurate.

@davecgh davecgh merged commit bc63bf4 into decred:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davecgh davecgh davecgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeoio @davecgh