mining: Run vote ntfn in a separate goroutine. #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
changed the title
This ensures the vote handling for the new background miner template happens in a goroutine in order to prevent blocking more transactions being added to the mempool and the vote itself from being immediately relayed to the rest of the network. It also prevents a potential deadlock that can occur due to the cycle created by being called under the mempool lock and in turn generating a template which itself attempts to grab the mempool lock to get the list of transactions. This really should be handled better overall, but this serves as a quick solution until the rest of the mining updates are made.
davecgh
force-pushed
the
mining_onvotereceived_goroutine
branch
from
e9b474c
to
b203c8a
Compare
dajohi
approved these changes
Apr 3, 2019
dnldd
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the vote handling for the new background miner template happens in a goroutine in order to prevent blocking more transactions being added to the
mempooland the vote itself from being immediately relayed to the rest of the network.It also prevents a potential deadlock that can occur due to the cycle created by being called under the
mempoollock and in turn generating a template which itself attempts to grab themempoollock to get the list of transactions.This really should be handled better overall, but this serves as a quick solution until the rest of the mining updates are made.