Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: Introduce v3 module. #1793

Merged
merged 4 commits into from
Jul 22, 2019
Merged

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Jul 21, 2019

This requires PR #1791.

This is marked WIP because it currently contains an override for rpcclient/v2.1.0 which must be removed once the aforementioned PR is merged and tagged. It is ready for review otherwise.


In order to support the latest dcrd RPC server version 6.0.0 requires the use of dcrjson/v3 and the newly introduced rpc/jsonrpc/types, which in turn requires a new major version of the rpcclient module.

Consequently, this introduces rpcclient/v3 to address the aforementioned items. A series of individual commits is provided to make the review process easier. Each commit message more thoroughly describes its purpose, but primarily they consist of the following:

  • Freeze version 2 of the rpcclient module
  • Remove the root module rpcclient override so building the software will still produce binaries based on the v2 module until the v3 module is fully released
  • Update to use dcrjson/v3@v3.0.0 and rpc/jsonrpc/types@v1.0.0.
  • Bump the module version to v3
  • Update docs for the new module version

Finally, it should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the v2 module.

@davecgh davecgh added this to the 1.5.0 milestone Jul 21, 2019
@davecgh davecgh mentioned this pull request Jul 21, 2019
This serves as the final release of version 2 of the rpcclient module.
All future releases will be moving to version 3 of the module.

Consequently, it bumps the module version as follows:

- github.com/decred/dcrd/rpcclient@v2.1.0

In addition, it updates the main module to use following module versions
as required:

- github.com/decred/dcrd/dcrutil@v1.4.0

It also removes the rpcclient override in the root module and updates it
so building the software will still produce binaries based on the v2
module until the v3 module is fully released.
This updates the rpcclient module to use v3 of the dcrjson module and v1
of the newly introduced rpc/jsonrpc/types module which now provides the
chain types separately in the same way the wallet types are separate.
@davecgh davecgh changed the title WIP: rpcclient: Introduce v3 module. rpcclient: Introduce v3 module. Jul 22, 2019
@davecgh davecgh merged commit 5e7afe5 into decred:master Jul 22, 2019
@davecgh davecgh deleted the rpcclient_introduce_v3 branch July 22, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants