rpcclient: Introduce v4 module. #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Jul 30, 2019
jrick
approved these changes
Jul 30, 2019
This serves as the final release of version 3 of the rpcclient module. All future releases will be moving to version 4 of the module. Since no changes have been made since the last release, it merely removes the rpcclient override in the root module and updates it so building the software will still produce binaries based on the v3 module until the v4 module is fully released.
This udpates the rpcclient module to use v2 of the dcrutil module and v2 of the chaincfg module since dcrutil/v2 requires it. While here it also updates the latest releases of the gcs and hdkeychain/v2 modules. The updated direct dependencies are as follows: - github.com/decred/dcrd/dcrutil/v2@v2.0.0 - github.com/decred/dcrd/gcs@v1.1.0 - github.com/decred/dcrd/hdkeychain/v2@v2.0.1
chappjc
approved these changes
Jul 30, 2019
davecgh
force-pushed
the
rpcclient_introduce_v4
branch
from
90a5151
to
e6bd4b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make use of
dcrutil/v2, which in turn requireschaincfg/v2, a new major version of therpcclientmodule is required becauserpcclient/v3accepts and returns types fromdcrutil/v1in its API.Consequently, this introduces
rpcclient/v4to address the aforementioned items. A series of individual commits is provided to make the review process easier. Each commit message more thoroughly describes its purpose, but primarily they consist of the following:rpcclientmodulerpcclientoverride so building the software will still produce binaries based on thev3module until thev4module is fully releaseddcrutil/v2@v2.0.0gcs@v1.1.0hdkeychain/v2@v2.0.1v4Finally, it should also be noted that this only introduces the new module and does not update anything to make use of it yet, so building the software will still produce binaries based on the
v3module.