mining: Remove dead code. #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Sep 9, 2019
This removes all of the code related to setting and updating cached templates in the block manager since they are no longer used. It is easy to see this is the case by considering that the only places that set cachedCurrentTemplate and cachedParentTemplate set them to nil.
davecgh
force-pushed
the
mining_remove_dead_code
branch
from
7a90b4c
to
48c0585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all of the code related to setting and updating cached templates in the block manager since they are no longer used.
It is easy to see this is the case by considering that the only places that set
cachedCurrentTemplateandcachedParentTemplateset them to nil.