mining: Correct priority calcs for Decred sizes. #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new interface named PriorityInputser and updates the functions that currently take a pointer to a blockchain.UtxoViewpoint struct to accept the interface instead. This removes the tight coupling between the two packages at the API boundary and allows callers to easily provide custom values if desired. It also updates the blockchain.UtxoViewpoint struct to implement the interface.
This changes the overhead value used when calculating transaction priorities for mining to the correct value for Decred transaction sizes.
This adds tests to ensure the priority calculation produces the expected values. In order to accomplish this, it introduces a mock priority input source which implements the newly introduced PriorityInputser interface.
dajohi
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #1966.
This changes the overhead value used when calculating transaction priorities for mining to the correct value for Decred transaction sizes and adds tests to ensure the priority calculation produces the expected values. In order to accomplish this, it introduces a mock priority input source which implements the newly introduced
PriorityInputserinterface.