connmgr: Allow pending outbound conn removal. #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
connmgr_allow_pending_outbound_conn_removal
branch
from
7da7209
to
67c8631
Compare
matheusd
approved these changes
Jan 15, 2020
dajohi
approved these changes
Jan 16, 2020
dnldd
approved these changes
Jan 23, 2020
Modify `dcrctl addnode <ip_addr:port> remove` to remove the address from the list of pending connections, preventing unnecessary retries.
This performs some minor cleanup to avoid extra allocations in the code added to handle removal of pending outbound connections as well as make it work properly with the new separation of the server from the rpcserver code since it runs a different code path.
davecgh
force-pushed
the
connmgr_allow_pending_outbound_conn_removal
branch
from
67c8631
to
a5480ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is a resubmission of #1842 with the requested changes applied in a separate commit since the author of that PR was not responsive in addressing them for several months. I've squashed the commits in that PR per standard practice and also updated the commit title to conform to the code contribution guidelines, but otherwise left them unchanged and attributed to the original author to ensure proper credit is given. Along those lines, I've added a separate commit which applies the requested changes as well as adds the additional code needed to make it work with incompatible changes that have since been made to master in the mean time.
This PR resolves #1725. Currently, if there is a call made by
dcrctl addnode <ip_addr:port> addto an unresponsive port, the connReq will repeatedly retry to connect until the timeout period has been reached.dcrctl addnode <ip_addr:port> removewill not stop the retry attempts. The PR removes the addr from the list of pending failed connections if thedcrctl addnode <ip_addr:port> removedoes not find an active connection.Fixes #1725.