schnorr: Remove internal hash func callback. #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
schnorr_remove_hashfunc_callback
branch
from
5fe2c55
to
77e8b85
Compare
jrick
approved these changes
Mar 20, 2020
This removes the hash func callback parameter for hashing the commitment data from the internal sign and verify functions in favor of just calling the real hash function directly. This is being done for several reasons: - It is not safe to use just any hash function, rather the hash function must have certain properties, so it's safer to make it explicit - There is only a single hash function, blake256, being used and thus having an extra unneeded parameter is not desirable - Any modifications to the commitment data invalidate existing signatures, so the internals of the function have to realistically be updated when making any changes anyway
davecgh
force-pushed
the
schnorr_remove_hashfunc_callback
branch
from
77e8b85
to
5bfb693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2129.
This removes the hash func callback parameter for hashing the commitment data from the internal sign and verify functions in favor of just calling the real hash function directly.
This is being done for several reasons: