secp256k1: Add overflow check to field val set. #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
secp256k1_fieldval_overflow_check
branch
from
3547308
to
3571781
Compare
matheusd
approved these changes
Apr 2, 2020
davecgh
force-pushed
the
secp256k1_fieldval_overflow_check
branch
2 times, most recently
from
ecffd1f
to
2c770ab
Compare
JoeGruffins
approved these changes
Apr 4, 2020
davecgh
force-pushed
the
secp256k1_fieldval_overflow_check
branch
2 times, most recently
from
935932b
to
cdb3f06
Compare
This modifies the SetBytes and SetByteSlice methods of the FieldVal type to return whether or not the provided value was greater than or equal to the field prime and adds tests to ensure it works as expected. This allows callers to easily check if a given uint256 value will fit within the field element without modular reduction and makes it more consistent with the ModNScalar type. Finally, it updates all of the callers in the repository accordingly.
alexlyp
approved these changes
Apr 6, 2020
davecgh
force-pushed
the
secp256k1_fieldval_overflow_check
branch
from
cdb3f06
to
8c6b52d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #2145.
This modifies the
SetBytesandSetByteSlicemethods of theFieldValtype to return whether or not the provided value was greater than or equal to the field prime and adds tests to ensure it works as expected.This allows callers to easily check if a given uint256 value will fit within the field element without modular reduction and makes it more consistent with the
ModNScalartype.Finally, it updates all of the callers in the repository accordingly.