Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcclient: bump to newer modules #2190

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented May 4, 2020

No description provided.

Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really needed for the updated require of the types module (to fix an undefined type when requiring rpcclient/v6 in another project), but bumps some other modules as well. I reviewed the changes between the gorilla websocket versions and this looks fine to me.

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this involves updating the github.com/gorilla/websocket dependency from v1.4.1 and v1.4.2, I reviewed all of the commits in between those two releases.

gorilla/websocket@v1.4.1...v1.4.2

@dajohi dajohi merged commit b60868c into decred:master May 4, 2020
@dajohi dajohi deleted the 111111111111111111111111111111111111111111111111 branch November 1, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants