txscript: Optimize sig enc check with mod n scalar. #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
txscript_checksigencoding_modnscalar
branch
from
595b9d0
to
a82d8d7
Compare
jrick
approved these changes
Jul 9, 2020
JoeGruffins
approved these changes
Jul 11, 2020
This modifies the signature encoding check function to use the new secp256k1.ModNScalar type for the half order check instead of a big int. The following benchmark shows a before and after comparison of a typical signature encoding check: benchmark old ns/op new ns/op delta ------------------------------------------------------------------- BenchmarkCheckSignatureEncoding 79.0 46.9 -40.63% benchmark old allocs new allocs delta -------------------------------------------------------------------- BenchmarkCheckSignatureEncoding 1 0 -100.00% benchmark old bytes new bytes delta -------------------------------------------------------------------- BenchmarkCheckSignatureEncoding 64 0 -100.00%
davecgh
force-pushed
the
txscript_checksigencoding_modnscalar
branch
from
a82d8d7
to
f7e984b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #2244.
This modifies the signature encoding check function to use the new
secp256k1.ModNScalartype for the half order check instead of a big int.The following benchmark shows a before and after comparison of a typical signature encoding check: