Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: add rpcserver.CPUMiner. #2286

Merged
merged 1 commit into from
Jul 26, 2020
Merged

multi: add rpcserver.CPUMiner. #2286

merged 1 commit into from
Jul 26, 2020

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jul 21, 2020 •
edited
Loading

This adds the rpcserver.CPUMiner interface to facilitate cpu miner related rpc tests.

Work towards #2069 .

@dnldd dnldd changed the title Add rpcserver cpuminer interface multi: add rpcserver.CPUMiner. Jul 21, 2020
davecgh
davecgh requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased on top of #2277 because it changes the API and therefore the interface will need to match for the most seamless integration.

Aside from that, it looks good.

@dnldd dnldd force-pushed the add_rpcserver_cpuminer_interface branch from d3a817a to 722c3af Compare July 21, 2020 23:54
@davecgh davecgh added this to the 1.6.0 milestone Jul 22, 2020
@dnldd dnldd force-pushed the add_rpcserver_cpuminer_interface branch from 722c3af to 3514ecc Compare July 25, 2020 23:57
@dnldd
multi: add rpcserver.CPUMiner.
8dfc234 
This adds the rpcserver.CPUMiner interface to
facilitate cpu miner related rpc tests.
@dnldd dnldd force-pushed the add_rpcserver_cpuminer_interface branch from 3514ecc to 8dfc234 Compare July 26, 2020 00:24
@davecgh davecgh merged commit ee0d826 into decred:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstaudt2 rstaudt2 rstaudt2 approved these changes

@davecgh davecgh davecgh approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dnldd @rstaudt2 @davecgh @JoeGruffins