Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: Support MSYS2 in simnet setup script. #2323

Merged
merged 1 commit into from
Aug 5, 2020
Merged

contrib: Support MSYS2 in simnet setup script. #2323

merged 1 commit into from
Aug 5, 2020

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Aug 5, 2020

This modifies the simnet environment setup script to make use of winpty when running under MSYS2 so that it works properly there.

@davecgh
contrib: Support MSYS2 in simnet setup script.
9bff4d1 
This modifies the simnet environment setup script to make use of winpty
when running under MSYS2 so that it works properly there.
@davecgh davecgh added this to the 1.6.0 milestone Aug 5, 2020
dnldd
dnldd approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@dnldd dnldd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jrick
jrick approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@jrick jrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unable to test on the unsupported platform, but it doesn't break the script anywhere else for me.

@davecgh davecgh merged commit 9bff4d1 into decred:master Aug 5, 2020
@davecgh davecgh deleted the contrib_simnet_setup_script_support_msys2 branch August 5, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnldd dnldd dnldd approved these changes

@jrick jrick jrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@davecgh @dnldd @jrick