mining: Remove leftover block manager facade iface. #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
mining_remove_leftover_package_separation_cruft
branch
from
a56416b
to
42d13b0
Compare
rstaudt2
approved these changes
Dec 16, 2020
dnldd
approved these changes
Dec 16, 2020
This reworks the mining template generator slightly to remove the leftover unexported block manager facade interface that was used as part of originally separating the code in a separate internal package. The following is a high level overview of the changes: - Introduces BgBlkTmplConfig for the background block template generator to mirror the standard approach used throughout the code - Removes local fields that are now in the new config struct - Removes blockManagerFacade interface which included: - IsCurrent - ForceReorganization - Adds IsCurrent function to new BgBlkTmplConfig struct - Adds ForceReorganizion to Config - Updates all code to account for the changes
davecgh
force-pushed
the
mining_remove_leftover_package_separation_cruft
branch
from
42d13b0
to
7f4d240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the mining template generator slightly to remove the leftover unexported block manager facade interface that was used as part of originally separating the code in a separate internal package.
The following is a high level overview of the changes:
BgBlkTmplConfigfor the background block template generator to mirror the standard approach used throughout the codeblockManagerFacadeinterface which included:IsCurrentForceReorganizationIsCurrentfunction to newBgBlkTmplConfigstructForceReorganiziontoConfig