stake: Comment on max SSGen outputs with treasury. #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jun 12, 2021
rstaudt2
force-pushed
the
max-ssgen-outputs-fix
branch
from
85b130e
to
aeca04d
Compare
rstaudt2
changed the title
This adds a comment to MaxOutputsPerSSGen indicating that if the treasury agenda is active, an OP_RETURN TV (treasury vote) output is additionally included in the last position when voting on a treasury spend. The MaxOutputsPerSSGen value does NOT account for this output, and should technically be increased by 1, but since the treasury agenda is already active this cannot be updated without a consensus vote.
rstaudt2
force-pushed
the
max-ssgen-outputs-fix
branch
from
aeca04d
to
c639bf1
Compare
davecgh
approved these changes
Jun 12, 2021
dnldd
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a comment to MaxOutputsPerSSGen indicating that if the treasury agenda is active, an OP_RETURN TV (treasury vote) output is additionally included in the last position when voting on a treasury spend.
The MaxOutputsPerSSGen value does NOT account for this output, and should technically be increased by 1, but since the treasury agenda is already active, this cannot be updated without a consensus vote.