-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explorer: reformat unminted legend value in charts #1448
Conversation
I always felt that "predicted" was a bit misleading because it's only a prediction assuming full block rewards, but once there's a single reduced block reward and missed vote it's a no longer a prediction; it is certain not to hit that amount. So it's really like a target/ideal coin supply. With that in mind, I wonder if we should (a) rename "predicted" and (b) not show the predicted line for the past, just the future. |
I'm guessing removal of the ideal line will result in complaints. Maybe just a better name? What is a compact but unambiguous way to describe it? Using a dashed line might be good too. |
That's good I suppose. Although I still think it's confusing to plot a line into the future that cannot be reached because at present there are already coins that will never be mined. Thus why I feel like the predicted supply or inflation limit line makes the most sense for data points in the future. It's not a big deal to me personally though. It's just that the two supply lines starting at genesis only say what coins did not get minted because of missed votes. Showing the inflation limit line for the future is where it gets confusing I think because that suggests that's where DCR supply could end up, but really it's that line minus the unminted value at present. |
Exactly what I had in mind. I like this. Let's ping the dcrdata chan for feedback. |
Resolves #1444