-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dex.decred.org exchange #1787
Conversation
Add an exchange.Exchange implementing type for a Decred DEX. On by default. Aggregated depth chart stacks deepest books first. Exchange colors are now static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I think we can get this in today. Just need to deal with book purge and a few other little things.
@@ -3,12 +3,11 @@ module github.com/decred/dcrdata/exchanges/v2 | |||
go 1.12 | |||
|
|||
require ( | |||
decred.org/dcrdex v0.1.1-beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stupidly made a tag that qualified as semver and we're stuck with it. Will want to make this go for whatever we have on either the master or release-0.1 branches. Seeing as I made that dumb tag I think we have no choice but to tag v0.1.1 at the same place as release-v0.1.1, so I'll probably do that.
@chappjc It appears you're on an older commit. I've updated the name in the "Decred Markets" table. See what you think now. I do see one more place I need to do that though. |
This is actually a pre-existing Dygraphs bug. For some reason, the left-most section is often unshaded if just one of its points is out of on the edge of the viewport. I see the same thing if I carefully zoom in on say Bittrex. It's just more apparent on dcrdex because the book only has a few price levels instead of the hundreds on other books. Once the book has more price bins, the chart will look normal. |
Add an
exchanges.Exchange
-implementing type for a Decred DEX. On by default.Aggregated depth chart stacks deepest books first. Exchange colors are now static.