Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 and eslint 8 fixes #1913

Merged
merged 3 commits into from
May 28, 2022
Merged

Node 18 and eslint 8 fixes #1913

merged 3 commits into from
May 28, 2022

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented May 16, 2022

This resolves a build error I encountered with Node 18, but is apparently related to the version of eslint-config-standard we were using that was not quite compatible with eslint 8.

standard/eslint-config-standard#202
standard/eslint-config-standard#209

This updates the npm deps to resolves that.

This also gets CI running on Node.js 16 and 18, which are the LTS and "Current" version supported: https://nodejs.org/en/download/

 dompurify                    ^2.3.5  →    ^2.3.8     
 url-parse                    ^1.5.4  →   ^1.5.10     
 @babel/core                ^7.16.12  →  ^7.17.10     
 @babel/eslint-parser        ^7.16.5  →   ^7.17.0     
 @babel/preset-env          ^7.16.11  →  ^7.17.10     
 babel-loader                 ^8.2.3  →    ^8.2.5     
 css-loader                   ^6.5.1  →    ^6.7.1     
 eslint                       ^8.7.0  →   ^8.15.0     
 eslint-config-standard      ^16.0.3  →   ^17.0.0     
 eslint-plugin-import        ^2.25.4  →   ^2.26.0     
 mini-css-extract-plugin      ^2.5.3  →    ^2.6.0     
 sass                        ^1.49.0  →   ^1.51.0     
 sass-loader                 ^12.4.0  →   ^12.6.0     
 stylelint                   ^14.3.0  →   ^14.8.2     
 stylelint-config-standard   ^24.0.0  →   ^25.0.0     
 stylelint-webpack-plugin     ^3.1.1  →    ^3.2.0     
 webpack                     ^5.67.0  →   ^5.72.1 

EDIT: since updated with the additional updates that support for node.js <14.15


Resolution for:

$ npm ci
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: eslint-config-standard@16.0.3
npm ERR! Found: eslint@8.7.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.7.0" from the root project
npm ERR!   peer eslint@"^7.5.0 || ^8.0.0" from @babel/eslint-parser@7.16.5
npm ERR!   node_modules/@babel/eslint-parser
npm ERR!     dev @babel/eslint-parser@"^7.16.5" from the root project
npm ERR!   6 more (eslint-plugin-es, eslint-plugin-import, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^7.12.1" from eslint-config-standard@16.0.3
npm ERR! node_modules/eslint-config-standard
npm ERR!   dev eslint-config-standard@"^16.0.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@7.32.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^7.12.1" from eslint-config-standard@16.0.3
npm ERR!   node_modules/eslint-config-standard
npm ERR!     dev eslint-config-standard@"^16.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@chappjc chappjc merged commit f89060c into decred:master May 28, 2022
@chappjc chappjc deleted the eslint8-fixes branch May 28, 2022 16:25
@chappjc chappjc added this to the 6.1 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant