Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts page #21

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Contracts page #21

merged 2 commits into from
Sep 8, 2019

Conversation

jholdstock
Copy link
Member

Contracts page is now correct and relevant for Decred.

@jholdstock jholdstock added the first-release Required before dcrdevdocs can go live label Sep 5, 2019
Copy link
Contributor

@s-ben s-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I'm only wondering if since in this page we're pretty much using word-for-word from the Bitcoin dev docs, we need to credit them, or do some rewriting. We could just leave a brief summary here saying Decred supports simple smart contracts like in Bitcoin, for example multi-sig contracts...possibly just link to outside resource on that for the example? Also, wondering here if the Decred opcodes enable some other type of simple smart contract worth mentioning? General differences to Bitcoin?

@jholdstock
Copy link
Member Author

I have mixed feelings about including this page in the site at all tbh. We could write our own version at a later date and explain how smart contracts are used for atomic swaps and VSP voting on tickets without taking custody of funds.

Shall we pull this out and create an issue, similar to #16 ?

@s-ben
Copy link
Contributor

s-ben commented Sep 7, 2019

I think the term 'contracts' is loaded and ill defined in the space generally. Its place in the Bitcoin docs almost seems provocative or political, even if it wasn't intended to be (see! we have smart contracts too!). I think its probably best to leave this out for now. We can cover the contract functionality we have (atomic swaps, voting contracts, etc.) in other places. If we change the consensus rules down the line to add more functionality to smart contracts, maybe we add a contracts page then.

@jholdstock jholdstock merged commit b0f07bf into master Sep 8, 2019
@jholdstock jholdstock mentioned this pull request Sep 8, 2019
@jholdstock
Copy link
Member Author

Removed the contracts page and opened #24 to implement it later

@jholdstock jholdstock deleted the contract branch November 23, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-release Required before dcrdevdocs can go live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants