client/webserver: remove legacy seed js validation #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently moved from hex seeds to mnemonics but had a leftover js check that only works for legacy seeds and errors for the new mnemonic seed format. This PR removes that legacy js validation and fixes a bug with PASSWORD_RESET_SUCCESS_MSG locale translation key. Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
|
How do I get to the set pw with app seed page? I don't see it it settings... Ohh, before login, right, nvm. |
JoeGruffins
approved these changes
Sep 12, 2024
buck54321
pushed a commit
to buck54321/dcrdex
that referenced
this pull request
Oct 17, 2024
* client/webserver: remove legacy seed js validation We recently moved from hex seeds to mnemonics but had a leftover js check that only works for legacy seeds and errors for the new mnemonic seed format. This PR removes that legacy js validation and fixes a bug with PASSWORD_RESET_SUCCESS_MSG locale translation key. * refresh password reset form before display --------- Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently moved from hex seeds to mnemonics but had a leftover js check that only works for legacy seeds and errors for the new mnemonic seed format.
This PR removes that legacy js validation and fixes a bug with
PASSWORD_RESET_SUCCESS_MSGlocale translation key.