admin: Add unban endpoint. #479
Conversation
JoeGruffins
force-pushed
the
unban
branch
2 times, most recently
from
29b78a0
to
8e4a861
Compare
JoeGruffins
force-pushed
the
unban
branch
2 times, most recently
from
b114a4c
to
ff63646
Compare
server/db/driver/pg/accounts.go
Outdated
| err := setRule(a.db, a.tables.accounts, aid, account.NoRule) | ||
| if err != nil { | ||
| // fatal unless 0 matching rows found. | ||
| if !errors.Is(err, errNoRows) { | ||
| a.fatalBackendErr(err) | ||
| } | ||
| return fmt.Errorf("error opening account %s: %v", aid, err) | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Please factor out this into (a *Archiver).setAccountRule and call it from both CloseAccount and OpenAccount or whatever we call it. You could even just call CloseAccount(aid, account.NoRule) from OpenAccount, but that might be confusing to read.
There was a problem hiding this comment.
You do still want the unexported setRule function, correct?
There was a problem hiding this comment.
Works well.
Only thing I'm wondering about pertains to the ban route as the dex admin cannot ban if --anarchy is enabled because of the check in (*AuthManager).Penalize. This check prevents auto-bans when Penalize is called from the Swapper and elsewhere, but I can still imagine needing to manually ban even if auto-ban is not enabled. Just something to investigate...
No description provided.