core,ui: add confirmation for currently waiting swap #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
requested changes
Nov 2, 2020
| @@ -188,7 +273,7 @@ type Order struct { | |||
| Cancelling bool `json:"cancelling"` | |||
| Canceled bool `json:"canceled"` | |||
| FeesPaid *FeeBreakdown `json:"feesPaid"` | |||
| FundingCoins []dex.Bytes `json:"fundingCoins"` | |||
| FundingCoins []*Coin `json:"fundingCoins"` | |||
There was a problem hiding this comment.
This and the the Match changes rule out 0.1.x unfortunately, which is no big deal as we'll move on to 0.2.0 right away.
|
Bump, but no rush. Just wanted to make sure this PR doesn't get lost. |
buck54321
commented
Nov 8, 2020
| @@ -56,6 +63,26 @@ func (c *Core) notify(n Notification) { | |||
| c.noteMtx.RUnlock() | |||
| } | |||
|
|
|||
| // updateCoreMatch performs a targeted update of a match in the User struct. | |||
| func (c *Core) updateCoreMatch(n *MatchNote) { | |||
There was a problem hiding this comment.
This function and the way it's called from the notification feed might be a model for a solution to #379.
chappjc
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add confirmation count to match cards on the order details page, for matches in
MakerSwapCastorTakerSwapCast. It's a bigger job than it sounds like, because 1) we weren't tracking confirmation count on our own swaps yet, and 2) I didn't think we should add the count unless it updated live, so the count, match status, and various coin ID links will update live now.There are just a few more pieces needed to make the whole page update live. Will save the rest for another PR.