Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: more chart interactivity #837

Merged
merged 2 commits into from
Nov 21, 2020
Merged

ui: more chart interactivity #837

merged 2 commits into from
Nov 21, 2020

Conversation

buck54321
Copy link
Member

@buck54321 buck54321 commented Nov 16, 2020

  1. Indicators on the depth chart for the user's orders. When the mouse hovers near the indicator, the order is highlighted in the "Your Orders" table. Conversely, when the mouse hovers over a row in the "Your Orders" table, the indicator is highlighted on the chart.
  2. Move the legend and hover info to the top.
  3. When a rate is entered in the order form for a limit order, display a line indicator at that rate on the depth chart.
  4. When the user hovers over an order in the buy/sell tables, display an indicator at that rate on the depth chart.
  5. Last zoom level is saved across markets and reloads.
  6. Display the total buy/sell volume.

Can test with the demo server.

@chappjc
Copy link
Member

chappjc commented Nov 17, 2020

This is great!

What's the "X" button supposed to do at the top right here:

image

Clicking it has no effect.

@buck54321
Copy link
Member Author

Oh. I meant to remove that. I just wanted to see how a button might work there, for when there are more options and chart types.

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chappjc chappjc merged commit fb6f3ea into decred:master Nov 21, 2020
@chappjc chappjc added this to the 0.2 milestone Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants