-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates dcrwallet-tickets.md with steps for v1.6 #1148
Updates dcrwallet-tickets.md with steps for v1.6 #1148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few minor things to look at.
There is a section under the "Decisions" heading which mentions delegation via multi-sig, that needs updating/removing. The mention of "smaller absolute fees" can also be removed.
@@ -47,32 +47,53 @@ Once `dcrwallet` is restarted with that line in `dcrwallet.conf`, your wallet wi | |||
|
|||
## VSP voting | |||
|
|||
To allow a VSP to vote for you, you first have to sign up for a VSP. A list of them can be found [here](../../proof-of-stake/how-to-stake.md#pos-using-a-voting-service-provider-vsp). After signing up, there should be directions for creating a new P2SH address and importing your multi-sig voting script. | |||
You can find a list of VSP [here](../../proof-of-stake/how-to-stake.md#pos-using-a-voting-service-provider-vsp). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSPs*
@@ -114,7 +135,7 @@ Third party sites such as <https://dcrstats.com> can be used to find the average | |||
|
|||
##### Ticket Price | |||
|
|||
To get the current ticket price, issue the `dcrctl --wallet getstakeinfo` command and look for the `difficulty` value. This is the price of each ticket in the current price window. You'll want to adjust your `spendlimit` argument in the `purchaseticket` command to be greater than this `difficulty` value when purchasing tickets manually. | |||
To get the current ticket price, issue the `dcrctl --wallet getstakeinfo` command and look for the `difficulty` value. This is the price of each ticket in the current price window. you will want to adjust your `spendlimit` argument in the `purchaseticket` command to be greater than this `difficulty` value when purchasing tickets manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You*
pooladdress=<VSP's Fee Collection Address> | ||
poolfees=<VSP's Required Reward Fee> | ||
``` | ||
You also need to specify options within your config file for your VSP as outlined [here.](#vsp-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an empty newline before this
|
||
If you don't want `ticketbuyer` to spend all of your funds, there is one more option which allows you to specify a balance which will not be spent: | ||
|
||
```no-highlight | ||
ticketbuyer.balancetomaintainabsolute=<balance> | ||
``` | ||
Note: The info below is now considered "legacy" and will be phased out at a later date. It is recommended to use the process [here](#vsp-voting) to purchase tickets with a VSP as of version 1.6.0 and above as it better respects privacy and requires no sign-up with the VSP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need an empty newline before this.
Without it, this text is formatted weirdly
Thanks very much for the code review! I will push the requested changes shortly. |
Removes verbiage related to legacy staking with VSP Adds new lines to fix formatting issues
Removes verbiage related to legacy staking with VSP Adds new lines to fix formatting issues
I have written changes to the dcrwallet-tickets.md page to add steps for staking with a VPS via vpsd as of v1.6.0, as well as added verbiage to differentiate steps that refer to the legacy method of purchasing tickets and delegating voting rights to a VSP.