Update dcrd/dcrwallet packages #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
dcrd-dcrw-update
branch
from
3d6ffb9
to
6f59d28
Compare
This changes the defer function in the test for channel backups to correctly close over the 'dave' variable. Without this closure, the shutdownAndAssert call would attempt to shutdown the original (non-restored) dave instead of the most recently created (restored) dave, causing a leak of a node during tests.
matheusd
force-pushed
the
dcrd-dcrw-update
branch
3 times, most recently
from
df3a332
to
c933218
Compare
This adds a check for the wallet funding transactions before proceeding to improve the reliability of the tests. It also increases the maximum time to sync the wallet due to ocasional failing tests in -race mode.
This changes the dcrd make target to build the required dcrd version in a temp dir instead of using go get. During development it's common to have a situation where not all dcrd modules have been tagged yet so go get might fail. It's easier to fetch the repo in a temp dir and build from there, so that all module replacements are correct.
This fixes the metadata in pseudo-version strings and tidies the module entries so that go 1.13 doesn't complain about wrong strings.
This removes most replace directives and switches to using a correct required version where possible. Replaces are still used for the unmerged/untagged lightning-onion version needed and for chaincfg v1.5.2 which is also untagged.
matheusd
force-pushed
the
dcrd-dcrw-update
branch
2 times, most recently
from
524cee5
to
fe0c363
Compare
matheusd
force-pushed
the
dcrd-dcrw-update
branch
from
fe0c363
to
afc324e
Compare
fguisso
suggested changes
Oct 7, 2019
This switches to using version 3 of the wallet packages. This is currently used an as-of-yet unreleased version of the packages since they have a few bug fixes that are useful and are likely to become the new released version in a short amount of time. In order to change to wallet v3 the rpcclient version for some components also had to be bumped to version 3 due to incompatibility in the API for dcrd's rescan rpc call.
This updates the rest of project to use the latest released major version of all dependencies.
matheusd
force-pushed
the
dcrd-dcrw-update
branch
from
afc324e
to
0fd7e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently using replaces for an unreleased version of the wallet packages and the lightning-onion packages.