Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set linter output format for local/CI #246

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Conversation

jholdstock
Copy link
Member

No description provided.

@dnldd
Copy link
Member

dnldd commented Sep 18, 2020

CI generated this:

 ./run_tests.sh: 20: ./run_tests.sh: [[: not found
+ OUT_FORMAT=colored-line-number
+ golangci-lint run --disable-all --deadline=10m --out-format=colored-line-number --enable=gofmt --enable=golint --enable=vet --enable=gosimple --enable=unconvert --enable=ineffassign

notice the not found in there?

@jholdstock
Copy link
Member Author

Sorted

Copy link
Member

@dnldd dnldd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jholdstock jholdstock closed this Oct 6, 2020
@jholdstock jholdstock deleted the output branch October 6, 2020 09:22
@jholdstock
Copy link
Member Author

Copying from Matrix, a quick demo of what this PR does:

This is a failing linter without 246 (This PR)
https://github.com/jholdstock/dcrpool/actions/runs/291068415
The only thing github can see is that a process ended with exit code != 0

This is the same failure with 246
https://github.com/jholdstock/dcrpool/actions/runs/291073141
Github can now interpret the issue - unreachable code warning from govet linter

Because github has this deeper understanding of build errors, you can see exactly why builds failed from directly within PRs, etc, without having to dig through logs

local CLI coloring is still enabled both before and after 246

I think the links above will go stale eventually. Github doesnt store build logs forever

@jholdstock jholdstock restored the output branch October 6, 2020 09:31
@jholdstock jholdstock reopened this Oct 6, 2020
@jholdstock jholdstock merged commit 605c133 into decred:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants