Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated fetchBucket funcs. #255

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Remove duplicated fetchBucket funcs. #255

merged 1 commit into from
Oct 11, 2020

Conversation

jholdstock
Copy link
Member

@jholdstock jholdstock commented Oct 9, 2020 •
edited
Loading

  • Replace multiple duplicated funcs with a single generic func which takes bucket ID as an arg.
  • Update tests to check for correct error type.

Part of #257

@jholdstock
Remove duplicated fetchBucket funcs.
e54ee9b 
- Replace multiple duplicated funcs with a single generic func which takes bucket ID as an arg.
- Update tests to check for correct error type.
@jholdstock jholdstock merged commit dba25a1 into decred:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnldd dnldd dnldd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jholdstock @dnldd